Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clickable row option for grid actions #15859

Merged
merged 6 commits into from Oct 11, 2019

Conversation

@jolelievre
Copy link
Contributor

jolelievre commented Oct 7, 2019

Questions Answers
Branch? 1.7.6.x
Description? To improve the UX of grids and allow the user to click on the row directly we added an option to grid definitions, and more precisely the row LinkAction so that a click on the row triggers it
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15831
How to test? We need to test all migrated pages with new grids, check that the row is now clickable to view/edit the row (pay close attention to the Category page where the action changes depending on the number of sub children). Pages affected by this PR: Backup, Category, CmsPageCategory, CmsPage, Contact, Currency, Customer, Employee, Language, ManufacturerAddress, Manufacturer, Meta, Profile, RequestSql, Supplier, Tax, WebserviceKey

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.6.2 milestone Oct 7, 2019
@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 7, 2019
@jolelievre jolelievre force-pushed the jolelievre:clickable-row branch 2 times, most recently from 98f0026 to ffca5c4 Oct 7, 2019
@sarjon

This comment has been minimized.

Copy link
Contributor

sarjon commented Oct 8, 2019

Shouldn't improvement go to next minor? 🤔

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

jolelievre commented Oct 8, 2019

Shouldn't improvement go to next minor? 🤔

Actually it's considered a regression because the feature was available in 1.6 (and all legacy pages in 1.7), that's why it's integrated in a patch version This feature had been forgotten on all migrated pages
But although it is a regression I had trouble labeling it as a bug fix 😅 But I can change type if needed @samuel-pires @eternoendless wdyt?

@jolelievre jolelievre force-pushed the jolelievre:clickable-row branch 3 times, most recently from 6fccefa to 7a440fa Oct 8, 2019
@samuel-pires

This comment has been minimized.

Copy link

samuel-pires commented Oct 8, 2019

But although it is a regression I had trouble labeling it as a bug fix 😅 But I can change type if needed @samuel-pires @eternoendless wdyt?

Well I see why you don't want to label it as bug, though the behavior differs from the one defined in the specs, thus, according to the @eternoendless is is considered a bug :)

@prestonBot prestonBot added the Bug label Oct 9, 2019
@jolelievre jolelievre force-pushed the jolelievre:clickable-row branch from 7a440fa to 7a06d94 Oct 10, 2019
@sarahdib sarahdib self-assigned this Oct 10, 2019
@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Oct 11, 2019

@jolelievre

This is not working for :

  • CmsPage
  • CmsPageCategory -> only working on the ID column
@jolelievre jolelievre force-pushed the jolelievre:clickable-row branch from 7a06d94 to b7ecc51 Oct 11, 2019
@jolelievre

This comment has been minimized.

Copy link
Contributor Author

jolelievre commented Oct 11, 2019

@sarahdib Ok t's fixed, I had forgotten to activate the feature for CMS pages

About the CMS category page, actually only non-interactive columns are clickable (to avoid breaking the behaviour on checkboxes, or toggle buttons). So only ID and description were clickable, but I added the position columns since it's just an information and no interaction, this should be more intuitive now.

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 11, 2019

Thank you @jolelievre

@matks matks merged commit 0d202a6 into PrestaShop:1.7.6.x Oct 11, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@samuel-pires

This comment has been minimized.

Copy link

samuel-pires commented Oct 11, 2019

Thanks @jolelievre 🎉

@jolelievre jolelievre deleted the jolelievre:clickable-row branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.