Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jquery in installation pages #15888

Merged

Conversation

@matthieu-rolland
Copy link
Contributor

matthieu-rolland commented Oct 9, 2019

Questions Answers
Branch? develop
Description? Update jquery version in installation process
Type? improvement
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15508
How to test? Try to install prestashop, everything should be ISO.

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 9, 2019
@matthieu-rolland matthieu-rolland added the WIP label Oct 9, 2019
@matthieu-rolland matthieu-rolland changed the title Install jquery upgrade Update jquery in installation pages Oct 9, 2019
@matthieu-rolland matthieu-rolland removed the WIP label Oct 9, 2019
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Oct 10, 2019

@matthieu-rolland I just reset a Travis test ;)

@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Oct 10, 2019

@matthieu-rolland The PR fixes two problems. Could you divide it in two PR, please ?

@matthieu-rolland matthieu-rolland force-pushed the matthieu-rolland:install-jquery-upgrade branch from c8e1a5a to d095510 Oct 10, 2019
@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

matthieu-rolland commented Oct 10, 2019

@matthieu-rolland The PR fixes two problems. Could you divide it in two PR, please ?

It should be fine now, I just needed to rebase my branch already, develop is evolving so fast :D

Copy link
Contributor

Progi1984 left a comment

Perfect ;)

@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 10, 2019
@matks matks added this to the 1.7.7.0 milestone Oct 11, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 11, 2019

Thank you @matthieu-rolland

@PierreRambaud PierreRambaud merged commit 222cb77 into PrestaShop:develop Oct 11, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.