Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct environment depending on what you are doing (dev, test, and prod) #15902

Merged
merged 5 commits into from Nov 13, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Oct 10, 2019

Questions Answers
Branch? develop
Description? Add _PS_ENV_ for symfony and legacy context and make a real distinction between dev, test and prod.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Required for #14894
How to test? Travis must be green. You're able to install prestashop in dev and production env.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 10, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/test-env branch from eaaba2d to 546c53a Oct 10, 2019
@PierreRambaud PierreRambaud added WIP and removed Bug labels Oct 10, 2019
Copy link
Contributor

jolelievre left a comment

Nice improvement! A few things worry me though

app/config/config_test.yml Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
src/Adapter/Environment.php Outdated Show resolved Hide resolved
src/Adapter/Environment.php Show resolved Hide resolved
@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Oct 10, 2019

Oh and also I think you can find a better name for this PR

@PierreRambaud PierreRambaud changed the title Better usage Use the correct environment depending on what you are doing (dev, test, and prod) Oct 10, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Oct 10, 2019

Oh and also I think you can find a better name for this PR

I press Enter too fast -_-

config/defines.inc.php Outdated Show resolved Hide resolved
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/test-env branch from 9a430de to 7e92586 Oct 11, 2019
Copy link
Contributor

Progi1984 left a comment

image
Why a right change ?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Oct 11, 2019

image
Why a right change ?

Because we can't execute this file without bash, even if a shebang is present, which is totally stupid. (My IDE automatically change the chmod of files containing a shebang)

@PierreRambaud PierreRambaud removed the WIP label Oct 11, 2019
@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers Oct 23, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/test-env branch from 7e92586 to bd81f5c Oct 23, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/test-env branch from bd81f5c to 8b85857 Nov 6, 2019
@sarahdib sarahdib self-assigned this Nov 13, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 13, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Nov 13, 2019
@PierreRambaud PierreRambaud merged commit ec37517 into PrestaShop:develop Nov 13, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/test-env branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.