Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides bad vouchers that should not be displayed to customers #15903

Merged
merged 4 commits into from Oct 14, 2019

Conversation

@matks
Copy link
Contributor

matks commented Oct 10, 2019

Questions Answers
Branch? develop
Description? Hides bad vouchers that should not be displayed to customer. Port of #8701
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Partially Customer can see all vouchers #13002. It hides the bad vouchers, but the bad data is still in database, just hidden.
How to test? See ticket. Bad vouchers (= vouchers that should not be visible) are not visible anymore

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 10, 2019
@matks matks changed the title Upport 8701 Hides bad vouchers that should not be displayed to customers Oct 10, 2019
@matks matks referenced this pull request Oct 10, 2019
@matks matks force-pushed the matks:upport-8701 branch from 277929b to 0ef2335 Oct 11, 2019
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Oct 14, 2019

Thank you for review

@matks matks merged commit 01bcd49 into PrestaShop:develop Oct 14, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@matks matks deleted the matks:upport-8701 branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.