Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces list dropdown - uses it in order list page #15908

Merged
merged 18 commits into from Oct 16, 2019

Conversation

@tomas862
Copy link
Member

tomas862 commented Oct 11, 2019

Questions Answers
Branch? develop
Description? Now each list can have choices. When you hover over the text the arrow is displayed . When you click on choices the dropdown appears - when you
Type? new feature
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #14741
How to test? Try to change several order statuses in the dropdown list of order page. You can access order list page via link admin-dev/index.php/sell/orders/orders/ . Also please rebuild assets before checking the functionality

This change is Reviewable

@tomas862 tomas862 requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 11, 2019
@matks matks added the migration label Oct 11, 2019
…-extension.js

Co-Authored-By: Mathieu Ferment <mathieu.ferment@prestashop.com>
@matks matks dismissed their stale review via 45bfb8f Oct 16, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 16, 2019

@tomas862 Fixed some git conflicts, be careful when pulling the PR

@matks matks added this to the 1.7.7.0 milestone Oct 16, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 16, 2019
$orderId,
$orderStatusId
)
);

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Oct 16, 2019

Contributor

😱

This comment has been minimized.

Copy link
@matks

matks Oct 16, 2019

Contributor

Bad git conflicts resolution using github UI >.<

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 16, 2019

Hi @tomas862 , nice work on this PR ! It's good for me 😄

QA Approved ✔️ !

Thanks !

@matks matks dismissed their stale review via f4e7c3f Oct 16, 2019
@matks
matks approved these changes Oct 16, 2019
@matks
matks approved these changes Oct 16, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 16, 2019

@matks matks merged commit 9ab55f1 into PrestaShop:develop Oct 16, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.