Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for product images in multishop BO #15909

Merged
merged 2 commits into from Oct 16, 2019

Conversation

@PrestaworksJonas
Copy link
Contributor

PrestaworksJonas commented Oct 11, 2019

Questions Answers
Branch? develop
Description? Fix for product images in backoffice for multishop and give option for getting images by shop id
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes issue #12061
How to test? 1. Go to a product in BO 2. Select one of your multishops in the context. 3. Upload a new image 4. This image will only be shown on the selected shop that it was uploaded on (this is the expected behavior, before this PR it does not work, see ticket)

This change is Reviewable

@PrestaworksJonas PrestaworksJonas requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 11, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Oct 11, 2019

Hello @PrestaworksJonas!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 11, 2019

@PrestaworksJonas Could you please rebase your PR on develop ? This should fix Travis failing build

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 11, 2019

Thanks for the PR @PrestaworksJonas 😄

@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.7.0 milestone Oct 11, 2019
@Progi1984 Progi1984 force-pushed the PrestaworksJonas:develop branch from 964b14e to 7db0307 Oct 14, 2019
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Oct 14, 2019

@matks

@PrestaworksJonas Could you please rebase your PR on develop ? This should fix Travis failing build

Done ;)

@Progi1984 Progi1984 closed this Oct 14, 2019
@Progi1984 Progi1984 reopened this Oct 14, 2019
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Oct 14, 2019

Reopened for relaunching PrettyCI

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 16, 2019

Looks like PrettyCI has been lost in the abyss

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 16, 2019

PrettyCI is gone for good now

@matks matks force-pushed the PrestaworksJonas:develop branch from 7db0307 to dca0b59 Oct 16, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 16, 2019

PR rebased on develop in an attempt to reset PrettyCI

@matks
matks approved these changes Oct 16, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 16, 2019

It worked 😄 thanks @PrestaworksJonas

@matks matks merged commit bc52360 into PrestaShop:develop Oct 16, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.