Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing currency in behat test #15912

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@matthieu-rolland
Copy link
Contributor

matthieu-rolland commented Oct 11, 2019

Questions Answers
Branch? develop
Description? Fix failing behat test by adding a missing currency to the context
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Travis must be green.

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 11, 2019
Copy link
Contributor

PierreRambaud left a comment

Something must be change in a test

…/Currency/currency.feature


fix calculation result

Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

matthieu-rolland commented Oct 11, 2019

Something must be change in a test

@PierreRambaud done !

@matks matks changed the title fix missing currency in behat test Fix missing currency in behat test Oct 11, 2019
@matks matks added this to the 1.7.7.0 milestone Oct 11, 2019
@matks
matks approved these changes Oct 11, 2019
@matks matks merged commit cbb7c64 into PrestaShop:develop Oct 11, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 11, 2019

Thank you @matthieu-rolland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.