Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of International > Taxes > Tax rules page #15915

Merged

Conversation

@matks
Copy link
Contributor

matks commented Oct 11, 2019

Questions Answers
Branch? develop
Description? Migration of International > Taxes > Tax rules page its actions and filters to symfony
Type? refacto
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10609
How to test? International > Taxes > Tax rule page should work as previously this PR, accessible via /improve/international/tax_rules_groups/

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 11, 2019
@RaimondasSapola RaimondasSapola force-pushed the RaimondasSapola:M/International/Taxes/TaxRules branch from 209a51e to 979ded0 Oct 11, 2019
@sarahdib sarahdib assigned sarahdib and unassigned sarahdib Oct 14, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Oct 17, 2019

@RaimondasSapola I'm sorry, I tried to rebase this PR but it seems I have not the required github rights to force-push your PR 😢 so you must do the rebase

@RaimondasSapola RaimondasSapola force-pushed the RaimondasSapola:M/International/Taxes/TaxRules branch from 5413689 to 285a4dc Oct 25, 2019
Copy link
Contributor

Progi1984 left a comment

Some naming

@RaimondasSapola RaimondasSapola force-pushed the RaimondasSapola:M/International/Taxes/TaxRules branch from cca15e7 to 1cf515e Nov 7, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Nov 8, 2019
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Nov 8, 2019
@Progi1984 Progi1984 merged commit b3f8ecd into PrestaShop:develop Nov 11, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.