Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set emailsubscription input required #15916

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@davidglezz
Copy link
Contributor

davidglezz commented Oct 11, 2019

Because there is no reason to subscribe to empty mail address.
Prevents accidental clicks or page reloading to show error.

Questions Answers
Branch? develop
Description? Because there is no reason to subscribe to empty mail address. Prevents accidental clicks or page reloading to show error.
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
How to test? Before: Subscribe with email "" → page reload → error message.
After: Subscribe with email "" → browser shows that the email is missing.

This change is Reviewable

Because there is no reason to subscribe to empty mail address.
Prevents accidental clicks or page reloading to show error.
@davidglezz davidglezz requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 11, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 11, 2019
@matks matks added this to the 1.7.7.0 milestone Oct 11, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 11, 2019

Thank you @davidglezz you're on fire lately 😄is this for Hacktoberfest ?

@matks matks merged commit 70a4836 into PrestaShop:develop Oct 11, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@davidglezz

This comment has been minimized.

Copy link
Contributor Author

davidglezz commented Oct 11, 2019

I didn't know him, I signed up now.
I am in the process of updating a store from 1.6 to 1.7 and if I do not try to fix it here, in each update I will have to fix it again. And also, I like to contribute.
Keep it up, you are doing a great job. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.