Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set emailsubscription input required #15916

Merged
merged 1 commit into from Oct 11, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Set emailsubscription input required

Because there is no reason to subscribe to empty mail address.
Prevents accidental clicks or page reloading to show error.
  • Loading branch information
davidglezz committed Oct 11, 2019
commit d076c98d6049e44bf3d3e6e390e0aff8da9740e3
@@ -49,6 +49,7 @@
value="{$value}"
placeholder="{l s='Your email address' d='Shop.Forms.Labels'}"
aria-labelledby="block-newsletter-label"
required
>
</div>
<input type="hidden" name="blockHookName" value="{$hookName}" />
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.