Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error SQL in getRecurseCategory method #15926

Merged
merged 5 commits into from Oct 17, 2019

Conversation

@marionf
Copy link
Contributor

marionf commented Oct 14, 2019

Questions Answers
Branch? develop
Description? Fix error SQL in getRecurseCategory method
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14366
How to test? Try to create a CMS category + CMS page with multistore enabled and without. Try to display the sitemap page in FO. Try to generate and display sitemap.xml through Google sitemap module

This change is Reviewable

@marionf marionf requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 14, 2019
marionf and others added 2 commits Oct 14, 2019
classes/CMSCategory.php Outdated Show resolved Hide resolved
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 16, 2019

@sarahdib what is wrong with this PR ?

@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Oct 16, 2019

@matks there is no step for testing and we don't know what the PR fix :
#14366 (comment)

@marionf

This comment has been minimized.

Copy link
Contributor Author

marionf commented Oct 17, 2019

@sarahdib

You can make non-regression tests: try to create a CMS category + CMS page with multistore enabled and without
I don't know if there is an action to do in back-office that allows to call the function getRecurseCategory

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 17, 2019

The function getRecurseCategory() is used in SitemapController::getPagesLinks() so it's used to compute the website sitemap

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 17, 2019

Hi @marionf ,

Unfortunately, does not work really well 😛

When trying to access the FO sitemap (without any action on BO), we have a PrestaShopDatabaseException :
PR15926 crash

@marionf

This comment has been minimized.

Copy link
Contributor Author

marionf commented Oct 17, 2019

@Robin-Fischer-PS it should be fixed now

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 17, 2019

@marionf I checked with/without multistore, the CMS creation is OK, and so is the sitemap on FO.

So it's QA Approved 😉

@matks matks added this to the 1.7.7.0 milestone Oct 17, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 17, 2019

Thank you @marionf and @carlead

@matks matks merged commit 0b1d8fd into PrestaShop:develop Oct 17, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.