Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose could not stats files #15942

Merged
merged 8 commits into from Dec 11, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Oct 14, 2019

Questions Answers
Branch? develop
Description? Be sure we use the primary user (1000 in Unix environment)
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15941
How to test? docker-compose up --build
Navigate to http://localhost:8001

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 14, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 16, 2019

Need one more review

@Quetzacoalt91 ?

@matks matks added this to the 1.7.7.0 milestone Oct 16, 2019
docker-compose.yml Outdated Show resolved Hide resolved
@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers Nov 6, 2019
@boubkerbribri

This comment has been minimized.

Copy link
Contributor

boubkerbribri commented Nov 18, 2019

Error when running command docker-compose up

image

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/docker-compose branch from b6518a4 to c28ec79 Nov 21, 2019
@PierreRambaud PierreRambaud removed the WIP label Nov 21, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Nov 21, 2019

No more in WIP.
Can a developer check if everything is ok :)

.docker/docker_run_git.sh Outdated Show resolved Hide resolved
Copy link
Contributor

Progi1984 left a comment

A small change from my side. But I ask a second review (@PrestaShop/prestashop-core-developers).

Copy link
Contributor

Progi1984 left a comment

Need a second review

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers Dec 10, 2019
Copy link
Contributor

jolelievre left a comment

Just two questions

.gitignore Show resolved Hide resolved
PS_DOMAIN: localhost:8001
PS_FOLDER_INSTALL: install-dev
PS_FOLDER_ADMIN: admin-dev
command: ["/tmp/wait-for-it.sh", "--timeout=60", "--strict", "mysql:3306", "--", "/tmp/docker_run_git.sh"]

This comment has been minimized.

Copy link
@jolelievre

jolelievre Dec 11, 2019

Contributor

So you need to run this command in both docker-compose.yml and in .docker/Dockerfile ?

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Dec 11, 2019

Author Contributor

Dockerfile is not related to the docker-compose behavior.
In .docker/Dockerfile we are building the container architecture / behavior, whereas when you use the docker-compose, you are waiting for some service to be up

Copy link
Contributor

jolelievre left a comment

@jolelievre jolelievre merged commit 1473660 into PrestaShop:develop Dec 11, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 11, 2019

Tested and approved!

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/docker-compose branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.