Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates Customer block of Order view page #15955

Merged
merged 7 commits into from Oct 17, 2019

Conversation

@sarjon
Copy link
Contributor

sarjon commented Oct 15, 2019

Questions Answers
Branch? develop
Description? Migrates Customer block of new Order view page.
Type? refacto
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #15821
How to test? ⚠️ Build assets before testing ⚠️ This PR does not add drop-down to these buttons (see https://prnt.sc/pk2y8a ), it will be done in another PR. Access /admin-dev/index.php/sell/orders/orders/1/view to see new Customer block.

This change is Reviewable

@sarjon sarjon requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 15, 2019
@matks matks added the migration label Oct 15, 2019
Copy link
Contributor

PierreRambaud left a comment

One little thing

@sarjon

This comment has been minimized.

Copy link
Contributor Author

sarjon commented Oct 16, 2019

@matks @PierreRambaud approve and QA?

@sarjon

This comment has been minimized.

Copy link
Contributor Author

sarjon commented Oct 16, 2019

This PR does not add drop-down to these buttons (see https://prnt.sc/pk2y8a ), it will be done in another PR.

@matks matks dismissed PierreRambaud’s stale review Oct 16, 2019

Requested changes applied

@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 16, 2019
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
@sarjon

This comment has been minimized.

Copy link
Contributor Author

sarjon commented Oct 17, 2019

@matks can you re-approve? It was already finished (approved + qa) not it's not again. 😭

@matks
matks approved these changes Oct 17, 2019
@matks matks added this to the 1.7.7.0 milestone Oct 17, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 17, 2019

Thank you @sarjon

@matks matks merged commit 745c5be into PrestaShop:develop Oct 17, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@sarjon sarjon deleted the sarjon:m/orders/view-customer branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.