Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use midnight for birthdate verification #15967

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@eternoendless
Copy link
Member

eternoendless commented Oct 15, 2019

Questions Answers
Branch? develop
Description? In some weird cases, this unit test would fail when using the current date. The best solution we've come up with is to compare birthdates using the date at midnight.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? Validated by unit tests

This change is Reviewable

@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 15, 2019
@@ -254,7 +254,7 @@ public function isBirthDateProvider()
array(true, '1991-04-19'),
array(true, '2015-03-22'),
array(true, '1945-07-25'),
array(false, '2020-03-19'),
array(false, '3000-03-19'),

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Oct 15, 2019

Contributor

❤️

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Oct 15, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 16, 2019

Thank you @eternoendless

@matks matks merged commit 7ce1ef6 into PrestaShop:develop Oct 16, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.