Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mexican tax rates #15969

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@LouiseBonnard
Copy link
Contributor

LouiseBonnard commented Oct 15, 2019

Questions Answers
Branch? develop
Description? Update localization packs data, add a new tax rate - feedback from the Mexican partner agency (here)
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? It is part of this EPIC.

This change is Reviewable

@LouiseBonnard LouiseBonnard requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 15, 2019
Copy link
Contributor

matthieu-rolland left a comment

edit...

@matthieu-rolland matthieu-rolland dismissed their stale review Oct 15, 2019

second developer opinion needed, the modifications seem legit but I have no idea if there are things to change in some other files ?

@matthieu-rolland matthieu-rolland merged commit 625577d into develop Oct 16, 2019
3 checks passed
3 checks passed
PrettyCI Code formatting
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984 Progi1984 deleted the LouiseBonnard-patch-2 branch Oct 22, 2019
@LouiseBonnard LouiseBonnard referenced this pull request Oct 25, 2019
44 of 44 tasks complete
@matks matks added this to the 1.7.7.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.