Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if customized product image exists before trying to delete it #15987

Merged
merged 4 commits into from Oct 23, 2019

Conversation

@jf-viguier
Copy link
Contributor

jf-viguier commented Oct 16, 2019

Questions Answers
Branch? develop
Description? If customized product image doesn't exists, false is returned and the product cannot be deleted from the cart.
Type? bug fix
Category? FO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? Fixes #15986
How to test? Cf my issue

This change is Reviewable

Fixes #15986
If customized product image doesn't exists, false is returned and the product cannot be deleted from the cart.
@jf-viguier jf-viguier requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 16, 2019
classes/Cart.php Outdated Show resolved Hide resolved
classes/Cart.php Outdated Show resolved Hide resolved
jf-viguier and others added 2 commits Oct 17, 2019
Thanks

Co-Authored-By: Progi1984 <progi1984@gmail.com>
tx

Co-Authored-By: Progi1984 <progi1984@gmail.com>
@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers Oct 17, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 17, 2019

Restarting Travis, I think recent docker hub downtime made it fail

@jf-viguier

This comment has been minimized.

Copy link
Contributor Author

jf-viguier commented Oct 17, 2019

@matks I don't know what to do.

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 17, 2019

@matks I don't know what to do.

Nothing 😄 CI is failing for reasons unrelated to your contribution. It's our task to fix it, not yours

@matks matks added migration and removed migration labels Oct 21, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 21, 2019

@jf-viguier Found it: Travis was right 💪there was a mistake so tiny I did not even notice
Fixed in dc43847

@jf-viguier

This comment has been minimized.

Copy link
Contributor Author

jf-viguier commented Oct 21, 2019

ok thanks @matks

@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 23, 2019
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.7.0 milestone Oct 23, 2019
@PierreRambaud PierreRambaud merged commit facbe1f into PrestaShop:develop Oct 23, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 23, 2019

Thanks @jf-viguier

@jf-viguier

This comment has been minimized.

Copy link
Contributor Author

jf-viguier commented Oct 23, 2019

Is this pr will be released in 1.7.7 ?

@jf-viguier jf-viguier deleted the jf-viguier:patch-6 branch Oct 23, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 23, 2019

Yes, as you can see on the right of your pull request :)
image

@jf-viguier

This comment has been minimized.

Copy link
Contributor Author

jf-viguier commented Oct 23, 2019

@PierreRambaud I've seen that but I don't know if it's a wish or a fact.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 23, 2019

@jf-viguier It's a fact, everything merged in a milestone will be in the related release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.