Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove final keyword from Lang entity #16026

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@jolelievre
Copy link
Contributor

jolelievre commented Oct 18, 2019

Questions Answers
Branch? 1.7.6.x
Description? Lang entity (nor any entity) must not be a final class or it causes problem with Doctrine proxies
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16025
How to test? ~

This change is Reviewable

…roblem with Dotrine proxies
@jolelievre jolelievre added this to the 1.7.6.2 milestone Oct 18, 2019
@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 18, 2019
@PierreRambaud PierreRambaud merged commit 35c533a into PrestaShop:1.7.6.x Oct 18, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 18, 2019

Thanks @jolelievre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.