Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces kpi design update for orders listing page - also includes layout changes for all kpi's in migrated pages #16033

Merged
merged 6 commits into from Nov 4, 2019

Conversation

@tomas862
Copy link
Member

tomas862 commented Oct 21, 2019

Questions Answers
Branch? develop
Description? Design changes mostly impacted in new order listing page located in admin-dev/index.php/sell/orders/orders. See below for more information of what has been changed
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15230
How to test? See below for what has been changed. Don't forget to rebuilt assets

new orders page design for kpis:

Screenshot (23)

I mentioned problem here in comments why gaps are still there: #15230 (comment)

other pages were impacted only with layout ( now kpi's are more condensed):

customers page:
Screenshot (24)

categories page:

Screenshot (25)

translations page:

Screenshot (26)


This change is Reviewable

@tomas862 tomas862 requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 21, 2019
@matks matks added the migration label Oct 21, 2019
@matks matks added this to the 1.7.7.0 milestone Oct 21, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 21, 2019

Nice job !

Co-Authored-By: Šarūnas Jonušas <jonusas.sarunas@gmail.com>
@TristanLDD

This comment has been minimized.

Copy link

TristanLDD commented Oct 24, 2019

Nice, @tomas862 could you fix these spacings:
Blue

Now we would have to replace all the icons from other impacted pages with material blue icons, but I guess this has to be done in another issue as it doesn't concern order page?

@tomas862 tomas862 dismissed stale reviews from matks and sarjon via a8500be Oct 31, 2019
@tomas862

This comment has been minimized.

Copy link
Member Author

tomas862 commented Oct 31, 2019

@TristanLDD yes, done it :) Here's how it looks like now
Screenshot (29)

and you are right, we should put it material icons replacement for other pages in another PR :)

@matks
matks approved these changes Oct 31, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 4, 2019
@Progi1984 Progi1984 merged commit 9d283f4 into PrestaShop:develop Nov 4, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.