Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove google plus from login footer google plus is dead #16041

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@mohamedaitbella
Copy link
Contributor

mohamedaitbella commented Oct 21, 2019

Questions Answers
Branch? develop
Description? Remove link to google plus from login template (google plus is dead)
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16040
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

@mohamedaitbella mohamedaitbella requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 21, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Oct 21, 2019

Hello @mohamedaitbella!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 21, 2019

Makes sense
@PrestaShop/prestashop-product-team I think it's 👍to remove this link, shall we put something else instead ?

@mohamedaitbella

This comment has been minimized.

Copy link
Contributor Author

mohamedaitbella commented Oct 21, 2019

no just remove the link for now thank you @matks

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Oct 21, 2019

@PrestaShop/prestashop-product-team I think it's +1 to remove this link, shall we put something else instead ?

Yes, we can just remove it as it's planned to remove them all on the migrated login page

@marionf marionf added PM ✔️ and removed waiting for PM labels Oct 21, 2019
@prestonBot prestonBot added the develop label Oct 21, 2019
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Oct 21, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 21, 2019
@Progi1984 Progi1984 merged commit 98b86f1 into PrestaShop:develop Oct 21, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.