Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upChange wording in FO when there is specific price by quantity #16069
Conversation
| @@ -1535,8 +1535,8 @@ public function getTemplateVarConfiguration() | |||
| 'quantity_discount' => array( | |||
| 'type' => ($quantity_discount_price) ? 'price' : 'discount', | |||
| 'label' => ($quantity_discount_price) | |||
| ? $this->getTranslator()->trans('Price', array(), 'Shop.Theme.Catalog') | |||
| : $this->getTranslator()->trans('Discount', array(), 'Shop.Theme.Catalog'), | |||
| ? $this->getTranslator()->trans('Unit Price', array(), 'Shop.Theme.Catalog') | |||
This comment has been minimized.
This comment has been minimized.
LouiseBonnard
Oct 23, 2019
Contributor
Suggested change
| ? $this->getTranslator()->trans('Unit Price', array(), 'Shop.Theme.Catalog') | |
| ? $this->getTranslator()->trans('Unit price', array(), 'Shop.Theme.Catalog') |
| ? $this->getTranslator()->trans('Price', array(), 'Shop.Theme.Catalog') | ||
| : $this->getTranslator()->trans('Discount', array(), 'Shop.Theme.Catalog'), | ||
| ? $this->getTranslator()->trans('Unit Price', array(), 'Shop.Theme.Catalog') | ||
| : $this->getTranslator()->trans('Unit Discount', array(), 'Shop.Theme.Catalog'), |
This comment has been minimized.
This comment has been minimized.
LouiseBonnard
Oct 23, 2019
Contributor
Suggested change
| : $this->getTranslator()->trans('Unit Discount', array(), 'Shop.Theme.Catalog'), | |
| : $this->getTranslator()->trans('Unit discount', array(), 'Shop.Theme.Catalog'), |
atomiix
force-pushed the
atomiix:wording-price-by-quantity
branch
from
9548dac
to
5efe849
|
LGTM ! |
This comment has been minimized.
This comment has been minimized.
Robin-Fischer-PS
commented
Nov 4, 2019
|
LGTM too ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
atomiix commentedOct 22, 2019
•
edited by eternoendless
2. Click on price tab
3. Click on add a specific price
4. Fill "Starting at" and "Apply a discount of" fields
5. See the product in FO
This change is