Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wording in FO when there is specific price by quantity #16069

Merged

Conversation

@atomiix
Copy link
Contributor

atomiix commented Oct 22, 2019

Questions Answers
Branch? develop
Description? This change the wording when there is volume discounts
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15817
How to test? 1. Edit a product (Catalog > Products)
2. Click on price tab
3. Click on add a specific price
4. Fill "Starting at" and "Apply a discount of" fields
5. See the product in FO

This change is Reviewable

@atomiix atomiix requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 22, 2019
@@ -1535,8 +1535,8 @@ public function getTemplateVarConfiguration()
'quantity_discount' => array(
'type' => ($quantity_discount_price) ? 'price' : 'discount',
'label' => ($quantity_discount_price)
? $this->getTranslator()->trans('Price', array(), 'Shop.Theme.Catalog')
: $this->getTranslator()->trans('Discount', array(), 'Shop.Theme.Catalog'),
? $this->getTranslator()->trans('Unit Price', array(), 'Shop.Theme.Catalog')

This comment has been minimized.

Copy link
@LouiseBonnard

LouiseBonnard Oct 23, 2019

Contributor
Suggested change
? $this->getTranslator()->trans('Unit Price', array(), 'Shop.Theme.Catalog')
? $this->getTranslator()->trans('Unit price', array(), 'Shop.Theme.Catalog')
? $this->getTranslator()->trans('Price', array(), 'Shop.Theme.Catalog')
: $this->getTranslator()->trans('Discount', array(), 'Shop.Theme.Catalog'),
? $this->getTranslator()->trans('Unit Price', array(), 'Shop.Theme.Catalog')
: $this->getTranslator()->trans('Unit Discount', array(), 'Shop.Theme.Catalog'),

This comment has been minimized.

Copy link
@LouiseBonnard

LouiseBonnard Oct 23, 2019

Contributor
Suggested change
: $this->getTranslator()->trans('Unit Discount', array(), 'Shop.Theme.Catalog'),
: $this->getTranslator()->trans('Unit discount', array(), 'Shop.Theme.Catalog'),
@atomiix atomiix force-pushed the atomiix:wording-price-by-quantity branch from 9548dac to 5efe849 Oct 23, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Nov 4, 2019
Copy link
Contributor

matthieu-rolland left a comment

LGTM !

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Nov 4, 2019

LGTM too !

@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.7.0 milestone Nov 4, 2019
@matthieu-rolland matthieu-rolland merged commit a1f161a into PrestaShop:develop Nov 4, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@atomiix atomiix deleted the atomiix:wording-price-by-quantity branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.