Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove require config.inc.php on all command and fix a notice #16072

Merged
merged 6 commits into from Oct 28, 2019

Conversation

@202-ecommerce
Copy link
Contributor

202-ecommerce commented Oct 22, 2019

Questions Answers
Branch? develop
Description? A notice PS_SSL_PORT already defined when you install a module in command line. See also our discussion #15515 #15515 (comment) You say : "we make sure we use require_once to avoid this if other scripts make good usage of require_once too" but that not the case.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? nc
How to test? Just try to install a module in command line, example of command: php bin/console prestashop:module install welcome

This change is Reviewable

@202-ecommerce 202-ecommerce requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 22, 2019
@202-ecommerce 202-ecommerce changed the title Fix notice due to require config.inc.php instead of require_once Remove require config.inc.php on all command and fix a notice Oct 23, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 23, 2019

@202-ecommerce Could you provide us the exact commands to reproduce and be sure everything is ok? :)

@202-ecommerce

This comment has been minimized.

Copy link
Contributor Author

202-ecommerce commented Oct 23, 2019

A command like :

php bin/console prestashop:module install welcome

capture d'écran_1

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Oct 25, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Oct 25, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 28, 2019

Thank you @202-ecommerce

@matks matks merged commit 14511a3 into PrestaShop:develop Oct 28, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 30, 2019

This fix solves an issue introduced in #15515 on 1.7.6.x branch. We fixed it on develop branch, but 1.7.6.x branch is not fixed yet.

Shall we backport this fix @PrestaShop/prestashop-core-developers ?

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 4, 2019

Backport done successfully in #16258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.