Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes to Orders page #16075

Merged
merged 5 commits into from Oct 31, 2019

Conversation

@sarjon
Copy link
Contributor

sarjon commented Oct 23, 2019

Questions Answers
Branch? develop
Description? 1. Fix missing location for products with combinations 2. Fix link to order view page from list 3. Fix products without images display in view page 4. Fix display address names instead of customer in order preview 4. Give more space to invoice data column so longer emails can fit.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Partially #14732
How to test? ⚠️ Build assets ⚠️ See description.

This change is Reviewable

@sarjon sarjon requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 23, 2019
@matks matks added the migration label Oct 23, 2019
@matks matks added this to the 1.7.7.0 milestone Oct 23, 2019
@sarjon

This comment has been minimized.

Copy link
Contributor Author

sarjon commented Oct 25, 2019

Rebased.

@sarjon sarjon force-pushed the sarjon:m/orders/preview-fixes branch from 3f90993 to 6625c89 Oct 25, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 31, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 31, 2019

Hi @sarjon , thanks for the PR 😄

It's OK for me.

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 31, 2019

Thank you @sarjon

@matks matks merged commit c28c1e6 into PrestaShop:develop Oct 31, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@sarjon sarjon deleted the sarjon:m/orders/preview-fixes branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.