Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Argentinian conversion and tax rates #16078

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

@LouiseBonnard
Copy link
Contributor

LouiseBonnard commented Oct 23, 2019

Questions Answers
Branch? develop
Description? Update localization packs data, update the conversion rate and add two extra tax rate - feedback from the Argentinian ambassador (here) and partner agency (here)
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? It is part of this EPIC.

This change is Reviewable

@LouiseBonnard LouiseBonnard requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 23, 2019
localization/ar.xml Outdated Show resolved Hide resolved
@LouiseBonnard LouiseBonnard mentioned this pull request Oct 25, 2019
44 of 44 tasks complete
@eternoendless eternoendless force-pushed the LouiseBonnard-patch-1 branch from 872bc37 to 1178f17 Nov 5, 2019
@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 5, 2019

Branch must be deleted after merge

@eternoendless eternoendless added this to the 1.7.7.0 milestone Nov 5, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Nov 6, 2019
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Nov 6, 2019

@LouiseBonnard You have a conflict on this PR.

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor Author

LouiseBonnard commented Nov 7, 2019

@Progi1984, thanks! I don't have a clue why there is a conflict here... could it be because two taxes (AR Reduced Rate) share the same name?
🤔

Co-Authored-By: Progi1984 <progi1984@gmail.com>
@eternoendless eternoendless force-pushed the LouiseBonnard-patch-1 branch from 1178f17 to 6df60b8 Nov 7, 2019
@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 7, 2019

Rebased

@PierreRambaud PierreRambaud merged commit 7e20a1d into develop Nov 7, 2019
3 checks passed
3 checks passed
PrettyCI Code formatting
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 7, 2019

@PierreRambaud PierreRambaud deleted the LouiseBonnard-patch-1 branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.