Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates Merchandise returns for Orders view #16084

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@sarjon
Copy link
Contributor

sarjon commented Oct 23, 2019

Questions Answers
Branch? develop
Description? Migrates Merchandise returns for Orders view
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #15825
How to test? ⚠️ Rebuild assets ⚠️ Merchandise returns block should work the same as in legacy page.

This change is Reviewable

@sarjon sarjon requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 23, 2019
@sarjon sarjon added the migration label Oct 23, 2019
@sarjon sarjon added this to the 1.7.7.0 milestone Oct 23, 2019
@sarjon sarjon force-pushed the sarjon:m/orders/merchandise-returns branch from 64a6c82 to 39cbd8b Oct 25, 2019
@sarjon

This comment has been minimized.

Copy link
Contributor Author

sarjon commented Oct 25, 2019

Rebased.

@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Oct 30, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 30, 2019

Hi @sarjon , thanks for the PR ! It's OK for me 😄

However, I have a suggestion for our UX and product friends 😛 :

@MatShir @TristanLDD :
The merchandise return block has two columns that have inconsistent labels (on Legacy and on Migrated page, and in the spec) :

  • "Carrier" which in fact display the status
  • "Tracking number" which in fact display the Return ID

I think it could be a good idea to fix this with the migration, what do you think ?

Here a screenshot :
pr16084 ux

Thanks !

@TristanLDD

This comment has been minimized.

Copy link

TristanLDD commented Oct 30, 2019

Hi @Robin-Fischer-PS,
I agree with you on the wording changes, Status and Return ID are much more relevant indeed.
However, considering the many last-minutes changes on order page migration and depending on workload estimations I don't know if we can prioritize it (@sarjon @MatShir )
@LouiseBonnard what do you think of these wording suggestions?

@sarjon

This comment has been minimized.

Copy link
Contributor Author

sarjon commented Oct 30, 2019

Just add suggestions for wording and we can easily merge it. :)

@matks matks force-pushed the sarjon:m/orders/merchandise-returns branch from 39cbd8b to 665543a Nov 6, 2019
@matks matks added the QA ✔️ label Nov 6, 2019
@matks
matks approved these changes Nov 6, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 6, 2019

Thank you @sarjon

@matks matks merged commit 17bfecd into PrestaShop:develop Nov 6, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@sarjon sarjon deleted the sarjon:m/orders/merchandise-returns branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.