Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement on product image generation for high definition images. #16097

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@Prestaworks
Copy link
Contributor

Prestaworks commented Oct 24, 2019

Questions Answers
Branch? develop
Description? Improvement on product image generation for high definition images.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #13957
How to test? generate images, and then turn on high definition images and genereate images again. No high definition images are created unless you delete all existing images before.

With this PW, the high definition images are handled separately.


This change is Reviewable

@Prestaworks Prestaworks requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 24, 2019
@Progi1984 Progi1984 changed the title Update AdminImagesController.php Improvement on product image generation for high definition images. Oct 24, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 24, 2019

Could you please create an issue to understand how to reproduce your problem?

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Oct 24, 2019

Could you please create an issue to understand how to reproduce your problem?

Here you go
#16113

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 28, 2019

Thank you @Prestaworks

@matks matks merged commit 989fc6d into PrestaShop:develop Oct 28, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.