Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes checkout js code easier to understand #16099

Merged

Conversation

@atomiix
Copy link
Contributor

atomiix commented Oct 24, 2019

Questions Answers
Branch? develop
Description? Refactoring checkout steps
Type? refacto
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15074
How to test? See #15042. This PR modifies the code but the behavior should be the same as described in #15042

This change is Reviewable

@atomiix atomiix requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 24, 2019
@PierreRambaud PierreRambaud changed the title makes checkout js code easier to understand Makes checkout js code easier to understand Oct 24, 2019
@atomiix atomiix force-pushed the atomiix:improve-js-checkout-behavior branch from 4c5d1ec to a35dbd3 Oct 24, 2019
@matks
matks approved these changes Oct 30, 2019
@colinegin colinegin added the High label Nov 6, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Nov 7, 2019
@PierreRambaud PierreRambaud merged commit 9f7cea9 into PrestaShop:develop Nov 7, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Nov 7, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 7, 2019

Thanks @atomiix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.