Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checked that ShippingCostTax values are not null before being formatted #16111

Merged
merged 2 commits into from Oct 24, 2019

Conversation

@Progi1984
Copy link
Contributor

Progi1984 commented Oct 24, 2019

Questions Answers
Branch? develop
Description? Checked that ShippingCostTax values are not null before being formatted
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16107
How to test? Check issue

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 24, 2019
@Progi1984 Progi1984 force-pushed the Progi1984:issue16107 branch from 3750266 to e5bc041 Oct 24, 2019
Copy link
Contributor

jolelievre left a comment

Thanks @Progi1984

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 24, 2019

Hi @Progi1984 ,

When applying the fix, the initial error is replaced by this new one :

crash order virtual 2

@Progi1984 Progi1984 dismissed stale reviews from PierreRambaud and jolelievre via 103e9ba Oct 24, 2019
@jolelievre jolelievre merged commit 6fb9739 into PrestaShop:develop Oct 24, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984 Progi1984 deleted the Progi1984:issue16107 branch Oct 24, 2019
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.