Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing placeholder in the Private Note textarea #16114

Merged

Conversation

@atomiix
Copy link
Contributor

atomiix commented Oct 24, 2019

Questions Answers
Branch? develop
Description? This adds a missing placeholder in the "Private note" textarea
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16024
How to test? See #15955 and take a look at the field "Private note"

This change is Reviewable

@atomiix atomiix requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 24, 2019
@atomiix atomiix force-pushed the atomiix:add-missing-private-note-placeholder branch from c839831 to d080b8b Oct 24, 2019
@@ -44,6 +60,9 @@ public function buildForm(FormBuilderInterface $builder, array $options)
->add('note', TextareaType::class, [
'required' => false,
'empty_data' => '',
'attr' => [
'placeholder' => $this->translator->trans('Add a note to the customer account. This note is only visible to you.', [], 'Admin.Orderscustomers.Feature'),

This comment has been minimized.

Copy link
@LouiseBonnard

LouiseBonnard Oct 25, 2019

Contributor
Suggested change
'placeholder' => $this->translator->trans('Add a note to the customer account. This note is only visible to you.', [], 'Admin.Orderscustomers.Feature'),
'placeholder' => $this->translator->trans('Add a note on this customer. It will only be visible to you.', [], 'Admin.Orderscustomers.Feature'),
@atomiix atomiix force-pushed the atomiix:add-missing-private-note-placeholder branch from d080b8b to fc65574 Oct 25, 2019
@PierreRambaud PierreRambaud merged commit c3538f1 into PrestaShop:develop Oct 25, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 25, 2019

Thanks  @atomiix

@atomiix atomiix deleted the atomiix:add-missing-private-note-placeholder branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.