Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS sizes for images in custom text block #16147

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@Klemart3D
Copy link
Contributor

Klemart3D commented Oct 28, 2019

Fix suggestion for [BOOM-6279] #9497
Need assets to be compiled (npm run build) to take effect.

Questions Answers
Branch? develop
Description? Add CSS sizes for images in custom text block
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9497
How to test? With mobile or browser in responsive mode
In the ticket : #9497#issuecomment-493936758

This change is Reviewable

Fix suggestion for [BOOM-6279] #9497
@Klemart3D Klemart3D requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 28, 2019
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Oct 28, 2019

Hi @Klemart3D, thank you for your contribution. Could you build assets in a second commit please ? Thanks

Reference : https://devdocs.prestashop.com/1.7/contribute/contribution-guidelines/#compiled-assets

@Klemart3D

This comment has been minimized.

Copy link
Contributor Author

Klemart3D commented Oct 28, 2019

Assets generated: Klemart3D@1eacc0c

@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Oct 28, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 8, 2019
@PierreRambaud PierreRambaud merged commit c4a1f5b into PrestaShop:develop Nov 8, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 8, 2019

Thanks @Klemart3D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.