Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter not being taken into account in grid export #16158

Merged
merged 5 commits into from Oct 29, 2019

Conversation

@matthieu-rolland
Copy link
Contributor

matthieu-rolland commented Oct 28, 2019

Questions Answers
Branch? 1.7.6.x
Description? Fix grid filters not being taken into account
Type? bug fix
Category? BO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? yes/no
Fixed ticket? Fixes #10293
How to test? Filter customer, and export as csv, your filter should be taken into account. Same for category listing.

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 28, 2019
@matthieu-rolland matthieu-rolland changed the title Fix filter not being taken into account in grid filters Fix filter not being taken into account in grid export Oct 28, 2019
@matthieu-rolland matthieu-rolland removed the WIP label Oct 28, 2019
@PierreRambaud PierreRambaud added this to the 1.7.6.2 milestone Oct 28, 2019
Copy link
Contributor

jolelievre left a comment

You can clean the Category definition

@@ -233,6 +235,11 @@ protected function getFilters()
'data-url' => $this->resetActionUrl,
'data-redirect' => $this->redirectActionUrl,
],
'reset_route' => 'admin_common_reset_search_by_filter_id',

This comment has been minimized.

Copy link
@jolelievre

jolelievre Oct 29, 2019

Contributor

Mmmm, I think you should remove the attr part

This comment has been minimized.

Copy link
@matthieu-rolland

matthieu-rolland Oct 29, 2019

Author Contributor

done

Copy link
Contributor

jolelievre left a comment

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Oct 29, 2019
@matthieu-rolland matthieu-rolland merged commit 63bff47 into PrestaShop:1.7.6.x Oct 29, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.