Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constraint on siret in CustomerType #16172

Merged

Conversation

@matthieu-rolland
Copy link
Contributor

matthieu-rolland commented Oct 29, 2019

Questions Answers
Branch? 1.7.6.x
Description? Fix error when adding a siret with a non numeric character in customer form
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16167
How to test? In BO > Customer > Add a customer: fill siret field with this value: 12345678-K, you should be able to save your modification. Please check that the SIRET input is still working in a relevant manner with B2B mode.

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 29, 2019
@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

matthieu-rolland commented Oct 29, 2019

Hello @colinegin , @marionf

The siret field was expecting a fully numeric value, this is why the "-" would not be accepted.
Also, today this field is not required (even in B2B mode).

The thing is, I'm not sure we have a format that would work for siret codes in every countries, so I removed any constraint on this field, since it's not required anyway.

What do you think ? Is it ok for you ?

@matks matks changed the title remove constraint on siret in CustomerType Remove constraint on siret in CustomerType Oct 29, 2019
@matks
matks approved these changes Oct 29, 2019
@matks matks added this to the 1.7.6.2 milestone Oct 29, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Oct 29, 2019
@matthieu-rolland matthieu-rolland merged commit ceeec64 into PrestaShop:1.7.6.x Oct 29, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.