Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Media Server for assets (CSS, JS, Images) #16180

Merged
merged 9 commits into from Nov 6, 2019
Merged

Conversation

@Progi1984
Copy link
Contributor

Progi1984 commented Oct 29, 2019

Questions Answers
Branch? develop
Description? Use Media Server for assets (CSS, JS, Images)
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9890
How to test? Test without SmartCache :
1. FO : In your PrestaShop, without MediaServer defined, all CSS/JS/images are called in your MediaServer
2. BO : In "Configure > Advanced > Performance", disable Smart cache for CSS & JS, and define a media server (CDN)
3. FO : all CSS/JS/images from theme or favicon are called from your CDN (except from modules)

Test with SmartCache :
1. FO : In your PrestaShop, without MediaServer defined, all CSS/JS/images are called in your MediaServer
2. BO : In "Configure > Advanced > Performance", enable Smart cache for CSS & JS, and define a media server (CDN)
3. FO : all CSS/JS/images from theme or favicon are called from your CDN (except from modules) and must be compiled (1 CSS & 1 JS for the front)

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 29, 2019
Copy link
Contributor

matthieu-rolland left a comment

minor change requested

classes/controller/FrontController.php Show resolved Hide resolved
@Progi1984 Progi1984 added the FO label Oct 29, 2019
@matthieu-rolland

This comment has been minimized.

Copy link
Contributor

matthieu-rolland commented Oct 29, 2019

@Progi1984 You just have to fix the prettyCI issue and it's a LGTM for me !

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

Progi1984 commented Oct 30, 2019

@matthieu-rolland 👌 for PrettyCI

Copy link
Contributor

jolelievre left a comment

Wow, this must have not been easy to figure out!!

classes/controller/FrontController.php Outdated Show resolved Hide resolved
classes/Tools.php Outdated Show resolved Hide resolved
classes/controller/FrontController.php Outdated Show resolved Hide resolved
classes/controller/FrontController.php Show resolved Hide resolved
@matthieu-rolland matthieu-rolland dismissed their stale review Oct 30, 2019

pretty CI ok

Progi1984 added 2 commits Oct 30, 2019
Copy link
Contributor

matthieu-rolland left a comment

lgtm

@matks matks added this to the 1.7.7.0 milestone Oct 31, 2019
@colinegin colinegin added the High label Nov 4, 2019
classes/Tools.php Outdated Show resolved Hide resolved
classes/Tools.php Outdated Show resolved Hide resolved
Copy link
Contributor

PierreRambaud left a comment

Some questions

@Progi1984 Progi1984 dismissed stale reviews from jolelievre and matthieu-rolland via ab9691c Nov 4, 2019
classes/Tools.php Outdated Show resolved Hide resolved
@Progi1984 Progi1984 requested a review from PierreRambaud Nov 5, 2019
@sarahdib sarahdib self-assigned this Nov 6, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 6, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 6, 2019

Thank you @Progi1984 and reviewers

@matks matks merged commit cfe9281 into PrestaShop:develop Nov 6, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.