Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ecuadorian tax rates #16181

Merged
merged 2 commits into from Oct 30, 2019

Conversation

@LouiseBonnard
Copy link
Contributor

LouiseBonnard commented Oct 29, 2019

Questions Answers
Branch? develop
Description? Update localization packs data, update tax rates - following the Avalara information here
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? It is part of this EPIC.

This change is Reviewable

@LouiseBonnard LouiseBonnard requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 29, 2019
@LouiseBonnard LouiseBonnard mentioned this pull request Oct 29, 2019
44 of 44 tasks complete
Copy link
Contributor

matthieu-rolland left a comment

lgtm

@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Oct 30, 2019

@LouiseBonnard there is a problem when we try to upgrade the pack Ecuadorian and when we install PS with Ecuadorian country there is an error in the BO

Capture d’écran 2019-10-30 à 11 08 40

Capture d’écran 2019-10-30 à 11 18 52

localization/ec.xml Outdated Show resolved Hide resolved
Co-Authored-By: Pablo Borowicz <pablo.borowicz@prestashop.com>
Copy link
Member

eternoendless left a comment

Looks good now

@sarahdib sarahdib added the QA ✔️ label Oct 30, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Oct 30, 2019
@Progi1984 Progi1984 merged commit 489c1f5 into develop Oct 30, 2019
3 checks passed
3 checks passed
PrettyCI Code formatting
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984 Progi1984 deleted the LouiseBonnard-patch-6 branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.