Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - Refactoring puppeteer tests #16194

Merged
merged 23 commits into from Oct 30, 2019

Conversation

@boubkerbribri
Copy link
Contributor

boubkerbribri commented Oct 29, 2019

Questions Answers
Branch? develop
Description? Refactoring puppeteer tests to be much easier to read
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? sanity tests on travis should pass

This change is Reviewable

@boubkerbribri boubkerbribri reopened this Oct 30, 2019
@boubkerbribri boubkerbribri marked this pull request as ready for review Oct 30, 2019
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 30, 2019
Copy link
Contributor

matthieu-rolland left a comment

LGTM

@SimonGrn SimonGrn merged commit 685ffe2 into PrestaShop:develop Oct 30, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@boubkerbribri boubkerbribri deleted the boubkerbribri:functionalFilters branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
4 participants
You can’t perform that action at this time.