Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local fonts in BO default theme #16209



Copy link

eternoendless commented Oct 30, 2019

Questions Answers
Branch? develop
Description? The default theme loaded its fonts from the Google fonts API, which obviously doesn't work when offline. This PR includes those fonts for legacy pages in the BO. A follow-up PR should fix this on migrated pages as well.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Partial fix for #12772
How to test? Load a legacy page while disconnected from the internet, see that the fonts are correct.

This PR also adds the webpack cleanup plugin on the default theme. Some assets were removed (see diff to learn which ones), which would indicate that they are no longer used. We should verify that they are indeed no longer used.

This change is Reviewable

@eternoendless eternoendless added this to the milestone Oct 30, 2019
@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 30, 2019
@Progi1984 Progi1984 added the BO label Oct 30, 2019

This comment has been minimized.

Copy link
Member Author

eternoendless commented Nov 4, 2019

Be aware that because the new theme is still loading fonts from Google, when switching from legacy pages to new pages fonts will have to be downloaded again by the client.

@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Nov 6, 2019
@PierreRambaud PierreRambaud merged commit 3a7a7de into PrestaShop:develop Nov 6, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Travis CI - Pull Request Build Passed

This comment has been minimized.

Copy link

PierreRambaud commented Nov 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
5 participants
You can’t perform that action at this time.