Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make id order available #16213

Merged
merged 2 commits into from Nov 14, 2019
Merged

Conversation

@atomiix
Copy link
Contributor

atomiix commented Oct 30, 2019

Questions Answers
Branch? develop
Description? Make {id_order} available everywhere where {order_name} is available
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #13964
How to test? replace {order_name} with {id_order} in order_conf mail template, buy any product on the store and look at the confirmation mail

This change is Reviewable

@atomiix atomiix requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 30, 2019
@@ -1134,7 +1135,7 @@ protected function createOrderCartRules(
'{voucher_num}' => $voucher->code,
'{firstname}' => $this->context->customer->firstname,
'{lastname}' => $this->context->customer->lastname,
'{id_order}' => $order->reference,
'{id_order}' => $order->id,

This comment has been minimized.

Copy link
@matks

matks Oct 31, 2019

Contributor

This is logical. However ... aren't we going to break modules that have been using this variable 😅 ?

ping @eternoendless : this would be kind of a BC break

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Nov 12, 2019

Contributor

It's not a BC, it's a bug fix. Otherwise all our bugs fixes are BC break 😅

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Nov 12, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Nov 14, 2019
@Progi1984 Progi1984 merged commit 7bc71ed into PrestaShop:develop Nov 14, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Nov 14, 2019

Thanks @atomiix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.