Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when deleting order cart rule #16222

Merged
merged 2 commits into from Oct 31, 2019

Conversation

@sarjon
Copy link
Contributor

sarjon commented Oct 31, 2019

Questions Answers
Branch? develop
Description? Fix error when deleting order cart rule in new order page.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #13890
How to test? ⚠️ Rebuild assets ⚠️ Access /admin-dev/index.php/sell/orders/orders/1/view and try to delete cart rule, it should work without any errors.

This change is Reviewable

@sarjon sarjon requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 31, 2019
@sarjon sarjon added the migration label Oct 31, 2019
@sarjon sarjon added this to the 1.7.7.0 milestone Oct 31, 2019
@matks
matks approved these changes Oct 31, 2019
@sarahdib sarahdib self-assigned this Oct 31, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Oct 31, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 31, 2019

Thank you @sarjon

@matks matks merged commit fb06896 into PrestaShop:develop Oct 31, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@sarjon sarjon deleted the sarjon:fix-delete-order-cart-rule branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.