Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tax information in combination table #16224

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@marionf
Copy link
Contributor

marionf commented Oct 31, 2019

Questions Answers
Branch? develop
Description? Add tax information in combinations table
Type? improvement
Category? BO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? Fixes #16223
How to test? Edit a product and click and combinations tab

This change is Reviewable

@marionf marionf requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 31, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 31, 2019

@marionf you're sure the data we display in this column is always "excluding tax" ?

@marionf

This comment has been minimized.

Copy link
Contributor Author

marionf commented Oct 31, 2019

@marionf you're sure the data we display in this column is always "excluding tax" ?

Yes, sure !

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 31, 2019

OK I trust you

@matks
matks approved these changes Oct 31, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Oct 31, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Oct 31, 2019
@Progi1984 Progi1984 merged commit 5206bf8 into PrestaShop:develop Oct 31, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.