Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Demo mode only if undefined #16237

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Oct 31, 2019

Questions Answers
Branch? develop
Description? Avoid PHP Notices caused by a defined constant, as given at the bottom of this description.
Type? improvement
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Nope
How to test? Basically, the way the demo works should remain the same. However, if another script (like https://github.com/PrestaShop/docker/blob/master/base/config_files/defines_custom.inc.php) sets the value, we should not have any more notices.
[Thu Oct 31 12:09:13.688334 2019] [php7:notice] [pid 20] [client 172.18.0.3:52676] PHP Notice:  Constant _PS_MODE_DEMO_ already defined in /var/www/html/config/defines.inc.php on line 45

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 31, 2019
@matks
matks approved these changes Oct 31, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 31, 2019

One more review and we can merge 👍

@PierreRambaud PierreRambaud merged commit 5acf31e into PrestaShop:develop Nov 4, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 4, 2019

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.