Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary require_once config.inc #16258

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@matks
Copy link
Contributor

matks commented Nov 4, 2019

Questions Answers
Branch? 1.7.6.x
Description? A notice PS_SSL_PORT already defined when you install a module in command line. Backport of #16072
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Try to install a module in command line, example of command: php bin/console prestashop:module install welcome. See discussion in #16072

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 4, 2019
@PierreRambaud PierreRambaud added this to the 1.7.6.2 milestone Nov 4, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 4, 2019
@matthieu-rolland matthieu-rolland merged commit 4f629ca into PrestaShop:1.7.6.x Nov 4, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@matks matks deleted the matks:backport-pr-16072 branch Nov 4, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Nov 4, 2019

Thank you @202-ecommerce 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.