Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix category checkbox redirect (Backport #16159) #16265

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@atomiix
Copy link
Contributor

atomiix commented Nov 4, 2019

Questions Answers
Branch? 1.7.6.x
Description? Prevent click action on identifier type table cells that have a checkbox
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16119
How to test? see #16119

This change is Reviewable

@atomiix atomiix requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 4, 2019
Copy link
Contributor

matthieu-rolland left a comment

looks fine to me

@@ -71,7 +71,7 @@ export default class LinkRowActionExtension {
* Only search for cells with non clickable contents to avoid conflicts with
* previous cell behaviour (action, toggle, ...)
*/
const clickableCells = $('td.data-type, td.identifier-type, td.badge-type, td.position-type', $parentRow)
const clickableCells = $('td.data-type, td.identifier-type:not(:has(.md-checkbox)), td.badge-type, td.position-type', $parentRow)

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Nov 4, 2019

Contributor

What about radio? text? etc 🤔 Are we sure, .md-checkbox is enough? what if a thrid part module use a custom css class?

Could we test something more generic?

Suggested change
const clickableCells = $('td.data-type, td.identifier-type:not(:has(.md-checkbox)), td.badge-type, td.position-type', $parentRow)
const clickableCells = $('td.data-type, td.identifier-type:not(:has(input)), td.badge-type, td.position-type', $parentRow)
Copy link
Contributor

PierreRambaud left a comment

Forget to add this comment 🙄

@atomiix atomiix dismissed stale reviews from matthieu-rolland and matks via d4c7c4a Nov 5, 2019
@atomiix atomiix force-pushed the atomiix:backport-pr-16159 branch from ca54293 to d4c7c4a Nov 5, 2019
@PierreRambaud PierreRambaud removed the QA ✔️ label Nov 5, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 5, 2019
@sarahdib sarahdib added this to the 1.7.6.2 milestone Nov 5, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 5, 2019

Thank you @atomiix

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 5, 2019

Tests are green but not reported to the PR, merging.

@eternoendless eternoendless merged commit 49f0aa8 into PrestaShop:1.7.6.x Nov 5, 2019
2 of 3 checks passed
2 of 3 checks passed
Travis CI - Pull Request Build Created
Details
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.