Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ajax exception when search for a product in order creation page #16266

Merged

Conversation

@matthieu-rolland
Copy link
Contributor

matthieu-rolland commented Nov 4, 2019

Questions Answers
Branch? develop
Description? Fix the broken ajax product search in order creation page
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16259
How to test? See below:

Steps to reproduce the behavior:

  • Install prestashop development mode (using /install-dev)
  • Click on Sell > Orders > Create new
  • Search and choose a customer
  • Search for products (ex: 'mug')
  • Products should be displayed in a select

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 4, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Nov 6, 2019

Hi @matthieu-rolland !

Your fix is OK, but I've got a new bug, I do not know if it's caused by your fix :

When I add a product, it's OK, but if I add a second product immediately after on the same order, it creates a new cart (with only the last product added) instead of adding the product to current cart.

See screen record :
https://drive.google.com/file/d/191hrSUes1-eW16bpVYjwkBze1U2TbtTW/view?usp=sharing

If this is not caused by your fix, we should create a new issue...

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor Author

matthieu-rolland commented Nov 6, 2019

Hi @matthieu-rolland !

Your fix is OK, but I've got a new bug, I do not know if it's caused by your fix :

When I add a product, it's OK, but if I add a second product immediately after on the same order, it creates a new cart (with only the last product added) instead of adding the product to current cart.

See screen record :
https://drive.google.com/file/d/191hrSUes1-eW16bpVYjwkBze1U2TbtTW/view?usp=sharing

If this is not caused by your fix, we should create a new issue...

This bug could not be reached because of the broken ajax query.... it seems that there's an issue bigger than the one fixed in this PR. I'll create an issue 👍

@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.7.0 milestone Nov 6, 2019
@PierreRambaud PierreRambaud merged commit c0e593b into PrestaShop:develop Nov 6, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.