Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https links to doc instead of http #16278

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@matks
Copy link
Contributor

matks commented Nov 5, 2019

Questions Answers
Branch? develop
Description? Use https links to doc instead of http
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 5, 2019
@PierreRambaud PierreRambaud merged commit 5d4c682 into PrestaShop:develop Nov 5, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Nov 5, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 5, 2019

No need QA. Thanks @matks

@matks matks deleted the matks:link-https-doc branch Nov 5, 2019
'debug_mode':
'en': 'http://doc.prestashop.com/display/PS17/Performance#Performance-Debugmode'
'en': 'https://doc.prestashop.com/display/PS17/Performance#Performance-Debugmode'
'fr': 'http://doc.prestashop.com/pages/viewpage.action?pageId=51840325#Param%%C3%%A8tresdeperformances-Modedebug'

This comment has been minimized.

Copy link
@matks

matks Nov 5, 2019

Author Contributor

Oh ? I notice a strange link here. Same on line below.

@@ -8,48 +8,48 @@ services:
- '@=service("prestashop.adapter.legacy.context").getContext().language ? service("prestashop.adapter.legacy.context").getContext().language.iso_code : "en-US"'
-
'team':
'en': 'http://doc.prestashop.com/display/PS17/Team'
'en': 'https://doc.prestashop.com/display/PS17/Team'
'fr': 'http://doc.prestashop.com/pages/viewpage.action?pageId=51840334'

This comment has been minimized.

Copy link
@matks

matks Nov 5, 2019

Author Contributor

Same here, strange link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.