Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording and add a link in product options tab #16281

Merged
merged 2 commits into from Nov 6, 2019

Conversation

@marionf
Copy link
Contributor

marionf commented Nov 5, 2019

Questions Answers
Branch? develop
Description? Update wording and add a link in product options tab
Type? improvement
Category? BO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? Fixes #16272
How to test? See issue

This change is Reviewable

@marionf marionf requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 5, 2019
@@ -176,7 +176,7 @@
<div class="row mt-4">
<div class="col-md-8">
<h2>{{ 'Attached files'|trans({}, 'Admin.Catalog.Feature') }}</h2>
<p class="subtitle">{{ 'Add files that customers can download directly on the product page (instructions, manual, recipe, etc.).'|trans({}, 'Admin.Catalog.Feature') }}</p>
<p class="subtitle">{{ 'Select the files (instructions, documentation, recipes, etc.) your customers can directly download on this product page.'|trans({}, 'Admin.Catalog.Feature') }} <br/> {{ "Need to browse all files? Go to [1]Catalog > Files[/1]"|trans({'[1]':'<a href="'~getAdminLink("AdminAttachments")~'">','[/1]':'</a>'}, 'Admin.Catalog.Feature')|raw }} </p>

This comment has been minimized.

Copy link
@Progi1984

Progi1984 Nov 6, 2019

Contributor
Suggested change
<p class="subtitle">{{ 'Select the files (instructions, documentation, recipes, etc.) your customers can directly download on this product page.'|trans({}, 'Admin.Catalog.Feature') }} <br/> {{ "Need to browse all files? Go to [1]Catalog > Files[/1]"|trans({'[1]':'<a href="'~getAdminLink("AdminAttachments")~'">','[/1]':'</a>'}, 'Admin.Catalog.Feature')|raw }} </p>
<p class="subtitle">{{ 'Select the files (instructions, documentation, recipes, etc.) your customers can directly download on this product page.'|trans({}, 'Admin.Catalog.Feature') }} <br/> {{ 'Need to browse all files? Go to [1]Catalog > Files[/1]'|trans({'[1]':'<a href="'~getAdminLink("AdminAttachments")~'">','[/1]':'</a>'}, 'Admin.Catalog.Feature')|raw }} </p>
…/Panels/options.html.twig

Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 6, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Nov 6, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 6, 2019

Thank you @marionf

@matks matks merged commit 144c46f into PrestaShop:develop Nov 6, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.