Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ajax spinner not disappearing after Ajax is done #16285

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@eternoendless
Copy link
Member

eternoendless commented Nov 5, 2019

Questions Answers
Branch? develop
Description? This fixes a regression in develop where the ajax spinner icon wouldn't stop spinning after the dashboard is loaded
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? Open up the dashboard, the spinner icon at the top left corner of the screen should disappear after a couple seconds.

This bug was a regression due to the jQuery version being upgraded. As noted in this page:

As of jQuery 1.9, all the handlers for the jQuery global Ajax events, including those added with the .ajaxStart() method, must be attached to document.


This change is Reviewable

@eternoendless eternoendless added this to the 1.7.7.0 milestone Nov 5, 2019
@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 5, 2019
@matks
matks approved these changes Nov 5, 2019
@matks matks added the waiting for QA label Nov 5, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Nov 6, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 6, 2019
@PierreRambaud PierreRambaud merged commit e25636f into PrestaShop:develop Nov 6, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 6, 2019

@eternoendless eternoendless deleted the eternoendless:fix-spinner branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.