Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests - Using the correct element in loop for brands tests #16297

Merged

Conversation

@boubkerbribri
Copy link
Contributor

boubkerbribri commented Nov 6, 2019

Questions Answers
Branch? develop
Description? Using the correct element in loop for brands tests
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? TEST_PATH="functional/BO/catalog/brandsAndSuppliers/brands/*" URL_FO=SHOP_URL npm run specific-test

This change is Reviewable

@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 6, 2019
@boubkerbribri boubkerbribri added the TE label Nov 6, 2019
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Nov 6, 2019
Copy link
Contributor

matthieu-rolland left a comment

lgtm

@matthieu-rolland matthieu-rolland merged commit e45bbc3 into PrestaShop:develop Nov 7, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
3 participants
You can’t perform that action at this time.