Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL upgrade for 1.7.7.0 (missing FROM) #16305

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@matks
Copy link
Contributor

matks commented Nov 7, 2019

Questions Answers
Branch? develop
Description? Fix SQL upgrade for 1.7.7.0 (missing FROM)
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Upgrade/Install for 1.7.7.0 should now work. Previously config key PS_PRICE_DISPLAY_PRECISION was not deleted.

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 7, 2019
matks referenced this pull request Nov 7, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Nov 7, 2019

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 7, 2019

I think we can accept this one as I was forced to do it in my own even if it was out of scope.

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 7, 2019

Thank you @matks

@eternoendless eternoendless merged commit 7b942ae into PrestaShop:develop Nov 7, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@matks matks deleted the matks:fix-sql-upgrade-1770 branch Nov 7, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Nov 7, 2019

Thank you @rblaurin

@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.