Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ps_dataprivacy, productcomments and ps_crossselling as native modules #16310

Merged
merged 2 commits into from Nov 14, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Nov 7, 2019

Questions Answers
Branch? develop
Description? Ps_dataprivacy, productcomments and ps_crossselling are now native modules.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15919
How to test? make sure you have theses modules installed after a fresh install :)

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 7, 2019
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Nov 7, 2019
@PierreRambaud PierreRambaud added WIP and removed waiting for QA labels Nov 7, 2019
@PierreRambaud PierreRambaud changed the title Add ps_dataprivacy and ps_crossselling as native modules Add ps_dataprivacy, productcomments and ps_crossselling as native modules Nov 7, 2019
@PierreRambaud PierreRambaud mentioned this pull request Nov 7, 2019
4 of 4 tasks complete
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/15919 branch from 40bf0cf to bf83ae8 Nov 12, 2019
@PierreRambaud PierreRambaud removed the WIP label Nov 12, 2019
- ps_dataprivacy
- ps_crossselling
- productcomments
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/15919 branch from bf83ae8 to 55e5e2b Nov 13, 2019
@sarahdib sarahdib self-assigned this Nov 13, 2019
@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Nov 14, 2019

@PierreRambaud modules are in the folder modules but not install

Capture d’écran 2019-11-14 à 08 53 29
Capture d’écran 2019-11-14 à 08 54 28
Capture d’écran 2019-11-14 à 08 54 37

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Nov 14, 2019

@sarahdib It's ok now, forget to commit one file :D

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/15919 branch from 3ef6b92 to 75a5218 Nov 14, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 14, 2019
@Progi1984 Progi1984 merged commit b37a696 into PrestaShop:develop Nov 14, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.