Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect display value in Price Tab of admin product controller #16312

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@WebXYAgency
Copy link

WebXYAgency commented Nov 7, 2019

Questions Answers
Branch? develop
Description? Use "+" operator instead of array_merge() when adding "No tax" option
Type? bug fix
Category? BO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? Fixes #16308
How to test? see issue #16308

This change is Reviewable

…b of admin product controller)
@WebXYAgency WebXYAgency requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 7, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Nov 7, 2019

Hello @WebXYAgency!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud PierreRambaud changed the title Fixes : issue #16308 Incorrect display value in Price Tab of admin product controller Nov 7, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Nov 8, 2019

Hi @WebXYAgency , thanks for the PR ! It's OK for QA 😄

@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.7.0 milestone Nov 8, 2019
@PierreRambaud PierreRambaud merged commit 4f5d70f into PrestaShop:develop Nov 8, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 8, 2019

Thanks @WebXYAgency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.