Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageManager::validateUpload : MimeType can't be check for SVG files #16316

Merged
merged 8 commits into from Nov 15, 2019

Conversation

@Progi1984
Copy link
Contributor

Progi1984 commented Nov 7, 2019

Questions Answers
Branch? develop
Description? * Permit to override the mime-type list in ImageManager::validateUpload
* Check the mimetype (if the file is not managed by the previous method in ImageManager::isRealImage
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Partial fix for #10600
How to test? Upload doesn't change (sample : Image Product use ImageManager::validateUpload)

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers Nov 7, 2019
@Progi1984 Progi1984 changed the title ImageManager : MimeType can't be check for SVG files ImageManager::validateUpload : MimeType can't be check for SVG files Nov 7, 2019
@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers Nov 7, 2019
Progi1984 added 2 commits Nov 8, 2019
classes/ImageManager.php Outdated Show resolved Hide resolved
classes/ImageManager.php Outdated Show resolved Hide resolved
classes/ImageManager.php Outdated Show resolved Hide resolved
Progi1984 added 2 commits Nov 8, 2019
@Progi1984 Progi1984 requested review from PierreRambaud and PrestaShop/prestashop-core-developers Nov 8, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 8, 2019

Please, don't forget to add the test part for our QA team :)

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

Progi1984 commented Nov 12, 2019

@PierreRambaud ✔️ Done

@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Nov 14, 2019
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.7.0 milestone Nov 14, 2019
@PierreRambaud PierreRambaud merged commit e7ad37e into PrestaShop:develop Nov 15, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 15, 2019

Thanks @Progi1984

@Progi1984 Progi1984 deleted the Progi1984:issue15939 branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.